simple-ecnu-thesis:0.1.0 #2094
Closed
simple-ecnu-thesis:0.1.0 #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typst-package-check
bot
changed the title
elegaanz
reviewed
Mar 31, 2025
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) [year] [fullname] | |||
Member
There was a problem hiding this comment.
You should update this line with actual information.
|
|
||
| // --------------------- 具体的字体 --------------------- | ||
| // 英文字体 | ||
| #let Times-New-Roman = "Times New Roman" |
Member
There was a problem hiding this comment.
The most common convention for variable names in Typst package is lowercase-kebab-case. It would be nice if you could rename the few variables in this file so that they don't have capital letters.
Member
|
Hello, just a message to remind you of the review I left a few weeks ago. If you don't have time to handle it for now, please let me know, I'll close this PR for inactivity (but then you can still submit your package again in another PR once it is ready). |
Member
|
Closing because of inactivity, as said above, feel free to open a new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting
A template to help ECNU students better use Typst for writing their theses, providing a structured directory in the Template and facilitating user customization.
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE